netdev - Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <464E8FD7.9030203@redhat.com>
Date:	Sat, 19 May 2007 13:49:11 +0800
From:	Eugene Teo <eteo@...hat.com>
To:	netdev@...r.kernel.org
CC:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Eugene Teo <eteo@...hat.com>
Subject: Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference

Randy Dunlap wrote:
> On Sat, 19 May 2007 13:13:07 +0800 Eugene Teo wrote:
> 
>> skb_peek() might return an empty list. skb should be checked before calling
>> llc_pdu_sn_hdr() with it.
>>
>> Spotted by the Coverity checker.
>>
>> Signed-off-by: Eugene Teo <eteo@...hat.com>
[...]
> 
> Oh, and your patch has spaces instead of tabs.  It's a hassle to
> get thunderbird to send a patch that preserves tabs.  See if this:
>    http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
> helps you any.

Here's a resend:

skb_peek() might return an empty list. skb should be checked before calling
llc_pdu_sn_hdr() with it.

Spotted by the Coverity checker.

Signed-off-by: Eugene Teo <eteo@...hat.com>

View attachment "2.6-llc_conn.patch" of type "text/x-patch" (404 bytes)