netdev - Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070518.230353.71553281.davem@davemloft.net>
Date:	Fri, 18 May 2007 23:03:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eteo@...hat.com
Cc:	netdev@...r.kernel.org, acme@...hat.com, randy.dunlap@...cle.com
Subject: Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference

From: Eugene Teo <eteo@...hat.com>
Date: Sat, 19 May 2007 13:49:11 +0800

> Spotted by the Coverity checker.

Why am I not surprised :-(

There is no bug here, if Coverity warns every single time skb_peek()
is used and not tested against NULL, that's a very serious shortcoming
of Coverity or what it has been taught about SKB queues.

It needs to learn that skb_queue_len() != 0 implies skb_peek() will
not return NULL sans locking errors.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html