lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 May 2007 18:16:35 -0400 From: Dave Jones <davej@...hat.com> To: Auke Kok <auke-jan.h.kok@...el.com> Cc: jeff@...zik.org, stable@...r.kernel.org, greg@...e.de, e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org, herbert@...dor.apana.org.au Subject: Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1) On Mon, May 21, 2007 at 02:51:35PM -0700, Auke Kok wrote: > Herbert Xu wrote: > "netif_poll_enable can only be called if you've previously called > netif_poll_disable. Otherwise a poll might already be in action > and you may get a crash like this." > > Removing the call to netif_poll_enable in e1000_open should fix this issue, > the only other call to netif_poll_enable is in e1000_up() which is only > reached after a device reset or resume. > > Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455 > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339 This probably doesn't solve the latter bug. The code you reference isn't there in the kernel tested in that bug (2.6.21) In 2.6.21, netif_poll_enable is only called from e1000_up(), not e1000_open() Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists