netdev - Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46522E6F.9060600@garzik.org>
Date:	Mon, 21 May 2007 19:42:39 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Auke Kok <auke-jan.h.kok@...el.com>
CC:	stable@...r.kernel.org, greg@...e.de,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	davej@...hat.com, herbert@...dor.apana.org.au
Subject: Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion
 hit in e1000_clean(), kernel 2.6.21.1)

Auke Kok wrote:
> Herbert Xu wrote:
> "netif_poll_enable can only be called if you've previously called
> netif_poll_disable.  Otherwise a poll might already be in action
> and you may get a crash like this."
> 
> Removing the call to netif_poll_enable in e1000_open should fix this issue,
> the only other call to netif_poll_enable is in e1000_up() which is only
> reached after a device reset or resume.
> 
> Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339
> 
> Tested by Doug Chapman <doug.chapman@...com>
> 
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
> ---
> 
>  drivers/net/e1000/e1000_main.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)

applied, though as a poster (DaveJ?) noted, I'm not sure it completely 
fixes the bug


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html