lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 May 2007 17:04:53 -0700 From: "Kok, Auke" <auke-jan.h.kok@...el.com> To: Jeff Garzik <jeff@...zik.org> CC: stable@...nel.org, Greg KH <greg@...ah.com>, e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org, davej@...hat.com, herbert@...dor.apana.org.au Subject: Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1) Jeff Garzik wrote: > Auke Kok wrote: >> Herbert Xu wrote: >> "netif_poll_enable can only be called if you've previously called >> netif_poll_disable. Otherwise a poll might already be in action >> and you may get a crash like this." >> >> Removing the call to netif_poll_enable in e1000_open should fix this issue, >> the only other call to netif_poll_enable is in e1000_up() which is only >> reached after a device reset or resume. >> >> Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455 >> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339 >> >> Tested by Doug Chapman <doug.chapman@...com> >> >> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com> >> Acked-by: Herbert Xu <herbert@...dor.apana.org.au> >> --- >> >> drivers/net/e1000/e1000_main.c | 4 ---- >> 1 files changed, 0 insertions(+), 4 deletions(-) > > applied, though as a poster (DaveJ?) noted, I'm not sure it completely > fixes the bug It fixes the HP IA64 issue reported by Doug Chapman, but indeed does not even apply to the FC bugzilla. I was mistaken due to the fact that I sent the code that introduced the bug a while ago, but it's not in 2.6.21 (it was in the e1000-fixes tree you had and merged after 2.6.21). So, this patch doesn't apply for -stable. Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists