netdev - Re: [PATCH] s2io: don't run MSI handlers if device is offline.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46560198.9080204@pobox.com>
Date:	Thu, 24 May 2007 17:20:24 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Linas Vepstas <linas@...tin.ibm.com>
CC:	Andrew Morton <akpm@...l.org>, linux-pci@...ey.karlin.mff.cuni.cz,
	netdev@...r.kernel.org,
	Ramkrishna Vepa <Ramkrishna.Vepa@...erion.com>,
	Sivakumar Subramani <sivakumar.subramani@...erion.com>,
	Sreenivasa Honnur <sreenivasa.honnur@...erion.com>,
	Rastapur Santosh <santosh.rastapur@...erion.com>,
	Wen Xiong <wenxiong@...ibm.com>
Subject: Re: [PATCH] s2io: don't run MSI handlers if device is offline.

Linas Vepstas wrote:
> Don't run any of the MSI handlers if the channel is off;
> also don't gather device statatistics. Also, netif_wake 
> not needed, per suggestions from
> Sivakumar Subramani <sivakumar.subramani@...erion.com>.
> 
> Signed-off-by: Linas Vepstas <linas@...tin.ibm.com>
> Cc: Ramkrishna Vepa <Ramkrishna.Vepa@...erion.com>
> Cc: Sivakumar Subramani <sivakumar.subramani@...erion.com>
> Cc: Sreenivasa Honnur <sreenivasa.honnur@...erion.com>
> Cc: Rastapur Santosh <santosh.rastapur@...erion.com>
> Cc: Wen Xiong <wenxiong@...ibm.com>

Why are the interrupt handlers being called at all, then?

This seems to be papering over another bug.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html