netdev - Re: [PATCH] s2io: don't run MSI handlers if device is offline.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070525182929.GB4323@austin.ibm.com>
Date:	Fri, 25 May 2007 13:29:29 -0500
From:	linas@...tin.ibm.com (Linas Vepstas)
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	Andrew Morton <akpm@...l.org>, linux-pci@...ey.karlin.mff.cuni.cz,
	netdev@...r.kernel.org,
	Ramkrishna Vepa <Ramkrishna.Vepa@...erion.com>,
	Sivakumar Subramani <sivakumar.subramani@...erion.com>,
	Sreenivasa Honnur <sreenivasa.honnur@...erion.com>,
	Rastapur Santosh <santosh.rastapur@...erion.com>,
	Wen Xiong <wenxiong@...ibm.com>
Subject: Re: [PATCH] s2io: don't run MSI handlers if device is offline.

On Thu, May 24, 2007 at 05:20:24PM -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> >Don't run any of the MSI handlers if the channel is off;
> >also don't gather device statatistics. Also, netif_wake 
> >not needed, per suggestions from
> >Sivakumar Subramani <sivakumar.subramani@...erion.com>.
> >
> Why are the interrupt handlers being called at all, then?
> 
> This seems to be papering over another bug.

Ahh ... are you suggesting that the arch should be performing 
this check in driver-independent code, and not delivering the
MSI if the pci channel is deemed offline? Yes, right, good point. 

So far, I'd hadn't really given this much thought, and had been 
letting the dev drivers perform this check, but, yes, it is probably 
better to have one common check performed in the generic arch-specific 
code, and the interrupt dropped, if the device is offlined.

I'll look into this.

--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html