lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 31 May 2007 22:25:04 +0200
From:	Oliver Hartkopp <>
To:	Patrick McHardy <>
CC:	Urs Thuermann <>,
	David Miller <>,
	Thomas Gleixner <>,
	Oliver Hartkopp <>,
	Urs Thuermann <>,
Subject: Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

Patrick McHardy wrote:
> Urs Thuermann wrote:
>> +	/* tx socket reference pointer: Loopback required if not NULL */
>> +	loop = *(struct sock **)skb->cb != NULL;
> Qdiscs might change skb->cb. Maybe use skb->sk?

Hi Patrick,

due to current projects Urs and me had only a short time today to
discuss the use of other skbuff-elements to implement the needed
loopback functionality. Urs remembered that the value of skb->sk was not
'stable' in the whole loopback and therefore the use of skb->cb was a
reasonable approach - and it was indeed working. Btw. triggered by your
remark, we're looking for alternatives.

Another thing is, that i would like to know, if Qdiscs would ever touch
skb's containing CAN-frames?!?
The MTU is 16 bytes (sizeof(struct can_frame)) and each skb contains
exact one CAN-frame.
What would a packet scheduler do with these skb's? IMO there is nothing
that could be optimized and linked together like in IPv4 / IPv6 data.

Would therefore skb->cb left unchanged in my skb's? Or is there any flag
that can be set in the skb to keep the packet scheduler's hands off?

Best regards,

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists