netdev - Re: [PATCH] e1000: disable polling before registering netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 01 Jun 2007 18:37:48 -0400
From:	Doug Chapman <doug.chapman@...com>
To:	Auke Kok <auke-jan.h.kok@...el.com>
Cc:	jeff@...zik.org, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org
Subject: Re: [PATCH] e1000: disable polling before registering netdevice

On Fri, 2007-06-01 at 10:22 -0700, Auke Kok wrote:
> To assure the symmetry of poll enable/disable in up/down, we should
> initialize the netdevice to be poll_disabled at load time. Doing
> this after register_netdevice leaves us open to another race, so
> lets move all the netif_* calls above register_netdevice so the
> stack starts out how we expect it to be.
> 
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Doug Chapman <doug.chapman@...com>


I tested this on my HP Integrity systems and it looks good.

thanks,

- Doug


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html