netdev - RE: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D5C1322C3E673F459512FB59E0DDC32903111571@orsmsx414.amr.corp.intel.com>
Date:	Tue, 19 Jun 2007 10:31:06 -0700
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>, <jeff@...zik.org>,
	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>, <hadi@...erus.ca>,
	<kaber@...sh.net>
Subject: RE: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

> From: PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>
> Date: Mon, 18 Jun 2007 11:42:29 -0700
> 
> > +
> > + 	/* The TX queue control structures */
> > + 	struct net_device_subqueue	*egress_subqueue;
> > + 	int				egress_subqueue_count;
> 
> Since every net device will have at least one subqueue, I 
> would suggest that you do this as follows:
> 
> 1) In net_device change the quoted part of the patch above to:
> 
> 	int				egress_subqueue_count;
> 	struct net_device_subqueue	egress_subqueue[0];
> 
> 2) In alloc_netdev():
> 
>    Factor (sizeof(struct egress_subqueue) * num_subqueues) into
>    the net_device allocation size, place the "priv" area after
>    the subqueues.
> 
> This will save us pointer dereferences on all of these quite 
> common accesses.

Thanks Dave!  I'll be putting this in today and run a test pass on it.
Thanks for the feedback.

-PJ Waskiewicz 
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html