netdev - Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070625153450.c5f535ca.akpm@linux-foundation.org>
Date:	Mon, 25 Jun 2007 15:34:50 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"pradeep singh" <pradeep.rautela@...il.com>
Cc:	trivial@...nel.org, netdev@...r.kernel.org, jgarzik@...ox.com
Subject: Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer
 dereferencing, take 2

On Thu, 21 Jun 2007 18:48:30 +0530
"pradeep singh" <pradeep.rautela@...il.com> wrote:

> diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c
> index 231ce43..006c634 100644
> --- a/drivers/net/chelsio/cxgb2.c
> +++ b/drivers/net/chelsio/cxgb2.c
> @@ -1022,6 +1022,11 @@ static int __devinit init_one(struct pci_dev *pdev,
>        mmio_start = pci_resource_start(pdev, 0);
>        mmio_len = pci_resource_len(pdev, 0);
>        bi = t1_get_board_info(ent->driver_data);
> +
> +       if (!bi) {
> +                CH_ERR("%s: Board info array index out of range\n",pci_name(pdev));
> +                goto out_disable_pdev;
> +        }
> 
>        for (i = 0; i < bi->port_number; ++i) {
>                struct net_device *netdev;

The chelsio driver is assuming that pci_device_id.driver_data has been
initialised to the board index, but I am unable to locate anywhere where
that initialisation actually happens.  Is this a bug?

(Who maintains this driver now?)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html