netdev - Re: [NET] au1000_eth: Fix warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070625160216.e9e29d7f.akpm@linux-foundation.org>
Date:	Mon, 25 Jun 2007 16:02:16 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org
Subject: Re: [NET] au1000_eth: Fix warnings.

On Sun, 24 Jun 2007 15:59:54 +0200
Ralf Baechle <ralf@...ux-mips.org> wrote:

> Fixed by including <linux/dma-mapping.h>:
> 
>   CC      drivers/net/au1000_eth.o
> drivers/net/au1000_eth.c: In function 'au1000_probe':
> drivers/net/au1000_eth.c:661: warning: implicit declaration of function 'dma_alloc_noncoherent'
> drivers/net/au1000_eth.c:802: warning: implicit declaration of function 'dma_free_noncoherent'
> 
> Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>
> 
> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> index c39ab80..c27cfce 100644
> --- a/drivers/net/au1000_eth.c
> +++ b/drivers/net/au1000_eth.c
> @@ -34,7 +34,7 @@
>   *
>   *
>   */
> -
> +#include <linux/dma-mapping.h>
>  #include <linux/module.h>
>  #include <linux/kernel.h>
>  #include <linux/string.h>

That's more than a warning fix.  On most platforms, dma_alloc_noncoherent()
is a #define so the driver just won't link there.

<looks>

But the driver is mips-only, and MIPS uses a regular C function for
dma_alloc_noncoherent(), so you got lucky.

Still, I'd say this is for-2.6.22.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html