netdev - Re: [RTNETLINK]: Add nested compat attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jun 2007 17:15:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	peter.p.waskiewicz.jr@...el.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org,
	shemminger@...ux-foundation.org
Subject: Re: [RTNETLINK]: Add nested compat attribute

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Date: Mon, 25 Jun 2007 16:23:02 -0700

> It looks like the one Patrick resent was the older version that requires
> a typecast.  This is the function prototype currently in the kernel:
> 
> +extern int rtattr_parse_nested_compat(struct rtattr *tb[], int maxattr,
> +				      struct rtattr *rta, void **data,
> int len);
> 
> This is the newer version:
> 
> +extern int __rtattr_parse_nested_compat(struct rtattr *tb[], int
> maxattr,
> +				        struct rtattr *rta, int len);
> +#define rtattr_parse_nested_compat(tb, max, rta, data, len) \
> +({	data = RTA_PAYLOAD(rta) >= len ? RTA_DATA(rta) : NULL; \
> +	__rtattr_parse_nested_compat(tb, max, rta, len); })
> +
> 
> I can send the update to what's in 2.6.23 as the first patch of my
> series, or I can write my function calls using the older callback (which
> isn't a problem).  Which would you prefer?

Either way is fine with me, just use the interface in the tree
for now and we can fix it up if we add the prototype change.

Meanwhile, Patrick please clear up the situation :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html