netdev - Re: [PATCH UPDATE] Ethernet driver for EISA only SNI RM200/RM400 machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Jun 2007 00:01:40 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:	netdev@...r.kernel.org, akpm@...ux-foundation.org,
	jgarzik@...ox.com
Subject: Re: [PATCH UPDATE] Ethernet driver for EISA only SNI RM200/RM400 machines

Thomas Bogendoerfer <tsbogend@...ha.franken.de> :
[...]
> diff --git a/drivers/net/sni_82596.c b/drivers/net/sni_82596.c
> new file mode 100644
> index 0000000..80e32ad
> --- /dev/null
> +++ b/drivers/net/sni_82596.c
[...]
> +static int __devinit sni_82596_probe(struct platform_device *dev)
> +{
[...]
> +	if (retval) {
> +		free_netdev(netdevice);
> +probe_failed:
> +		if (mpu_addr)
> +			iounmap(mpu_addr);
> +		if (ca_addr)
> +			iounmap(ca_addr);
> +		if (eth_addr)
                    ^^^
> +			iounmap(ca_addr);
                                ^^
-> typo

Please use plain goto with proper labels and remove the tests.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html