netdev - Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <468626BC.80805@pobox.com>
Date:	Sat, 30 Jun 2007 05:47:40 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	Arjan van de Ven <arjan@...radead.org>, netdev@...r.kernel.org,
	Edward Hsu <edward_hsu@...ltek.com.tw>
Subject: Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's
 r8169 driver

Francois Romieu wrote:
> Jeff Garzik <jgarzik@...ox.com> :
>> Arjan van de Ven wrote:
>>>> +	pci_write_config_byte(tp->pci_dev, PCI_LATENCY_TIMER, 0x40);
>>> can you create a pci_set_latency_timer() for this please?
> [...]
>>>> +	if (tp->mac_version <= RTL_GIGA_MAC_VER_06)
>>>> +		pci_write_config_byte(tp->pci_dev, PCI_CACHE_LINE_SIZE, 
>>>> 0x08);
>>> and something for this as well?
>> Why?  Nothing here seems generic to me.
> 
> I.e. no need for pci_set_latency_timer(struct pci_dev *dev, u8 latency)
> neither pci_set_cache_line_size(struct pci_dev *dev, u8 size) ?

Yeah.  When it gets to be a one-line wrapper like that, I don't see much 
additional value in pci_set_cache_line_size() over 
pci_write_config_byte(,PCI_CACHE_LINE_SIZE,).

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html