[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <46871F0B.6020801@garzik.org>
Date: Sat, 30 Jun 2007 23:27:07 -0400
From: Jeff Garzik <jeff@...zik.org>
To: Dhananjay Phadke <dhananjay.phadke@...il.com>
CC: Michael Buesch <mb@...sch.de>, netdev@...r.kernel.org,
rob@...xen.com, Milan Bag <mbag@...xen.com>,
Wen Xiong <wenxiong@...ibm.com>
Subject: Re: [PATCH 3/3] NetXen: Graceful teardown of interface and hardware
upon module unload
Dhananjay Phadke wrote:
> This stage is safe to bail out on signal. It's initializing about a
> hundred registers
> and trying to guaranty by retrying, so can get stretched too much on
> faulty h/w.
This implies that you have -add- code to check for and handle signals at
each delay point. Don't bother. Too much code bloat for negligable gain.
It is better just to remove the _interruptible, for many reasons.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists