netdev - Re: [PATCH] Cleanup usbnet_probe() return value handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707020914.38479.david-b@pacbell.net>
Date:	Mon, 2 Jul 2007 09:14:38 -0700
From:	David Brownell <david-b@...bell.net>
To:	Peter Korsgaard <jacmet@...site.dk>
Cc:	netdev@...r.kernel.org, dbrownell@...rs.sourceforge.net
Subject: Re: [PATCH] Cleanup usbnet_probe() return value handling

On Monday 02 July 2007, Peter Korsgaard wrote:
> usbnet_probe() handles a positive return value from the driver bind()
> function as success, but will later only setup the status handler if the
> return value was zero, leading to confusion. Patch adjusts this to only
> accept 0 as success in both checks.

I'd rather see the later test updated to match this one.
(Good catch!)

The return convention is "negative means error".  There's
code in USB which has multiple nonnegative success codes.

In particular usb_control_msg(), which would very naturally
used as the body of a bind() method, returns negative or
the number of bytes transferred.

- Dave


> Signed-off-by: Peter Korsgaard <jacmet@...site.dk>
> ---
>  drivers/net/usb/usbnet.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.22-rc7/drivers/net/usb/usbnet.c
> ===================================================================
> --- linux-2.6.22-rc7.orig/drivers/net/usb/usbnet.c
> +++ linux-2.6.22-rc7/drivers/net/usb/usbnet.c
> @@ -1182,7 +1182,7 @@
>  	// NOTE net->name still not usable ...
>  	if (info->bind) {
>  		status = info->bind (dev, udev);
> -		if (status < 0)
> +		if (status != 0)
>  			goto out1;
>  
>  		// heuristic:  "usb%d" for links we know are two-host,
> 
> -- 
> Bye, Peter Korsgaard
> 


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html