netdev - Re: [PATCH] Cleanup usbnet_probe() return value handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sl86juel.fsf@p4.be.48ers.dk>
Date:	Tue, 03 Jul 2007 00:46:42 +0200
From:	Peter Korsgaard <jacmet@...site.dk>
To:	David Brownell <david-b@...bell.net>
Cc:	netdev@...r.kernel.org, dbrownell@...rs.sourceforge.net
Subject: Re: [PATCH] Cleanup usbnet_probe() return value handling

>>>>> "David" == David Brownell <david-b@...bell.net> writes:

Hi,

 David> I'd rather see the later test updated to match this one.
 David> (Good catch!)

 David> The return convention is "negative means error".  There's
 David> code in USB which has multiple nonnegative success codes.

Ok, updated patch does that instead.

 David> In particular usb_control_msg(), which would very naturally
 David> used as the body of a bind() method, returns negative or
 David> the number of bytes transferred.

Yeah, that was the original problem in my dm9601 driver.

usbnet_probe() handles a positive return value from the driver bind()
function as success, but will later only setup the status handler if the
return value was zero, leading to confusion. Patch adjusts this to accept
positive values as success in both checks.

Signed-off-by: Peter Korsgaard <jacmet@...site.dk>
---
 drivers/net/usb/usbnet.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.22-rc7/drivers/net/usb/usbnet.c
===================================================================
--- linux-2.6.22-rc7.orig/drivers/net/usb/usbnet.c
+++ linux-2.6.22-rc7/drivers/net/usb/usbnet.c
@@ -1208,7 +1208,7 @@
 			status = 0;

 	}
-	if (status == 0 && dev->status)
+	if (status >= 0 && dev->status)
 		status = init_status (dev, udev);
 	if (status < 0)
 		goto out3;

-- 
Bye, Peter Korsgaard

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html