netdev - Re: [PATCH] Cleanup usbnet_probe() return value handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Jul 2007 21:34:13 -0700
From:	David Brownell <david-b@...bell.net>
To:	Peter Korsgaard <jacmet@...site.dk>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Cleanup usbnet_probe() return value handling

On Monday 02 July 2007, Peter Korsgaard wrote:

> usbnet_probe() handles a positive return value from the driver bind()
> function as success, but will later only setup the status handler if the
> return value was zero, leading to confusion. Patch adjusts this to accept
> positive values as success in both checks.
> 
> Signed-off-by: Peter Korsgaard <jacmet@...site.dk>

Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>

... though I'd adjust comments to say "non-negative" rather
than "positive".  Most folks won't say that zero is positive.


> ---
>  drivers/net/usb/usbnet.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.22-rc7/drivers/net/usb/usbnet.c
> ===================================================================
> --- linux-2.6.22-rc7.orig/drivers/net/usb/usbnet.c
> +++ linux-2.6.22-rc7/drivers/net/usb/usbnet.c
> @@ -1208,7 +1208,7 @@
>  			status = 0;
>  
>  	}
> -	if (status == 0 && dev->status)
> +	if (status >= 0 && dev->status)
>  		status = init_status (dev, udev);
>  	if (status < 0)
>  		goto out3;
> 
> -- 
> Bye, Peter Korsgaard
> 


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html