lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4693B6F5.6070603@garzik.org> Date: Tue, 10 Jul 2007 12:42:29 -0400 From: Jeff Garzik <jeff@...zik.org> To: Peter Korsgaard <jacmet@...site.dk> CC: David Brownell <david-b@...bell.net>, netdev@...r.kernel.org, dbrownell@...rs.sourceforge.net Subject: Re: [PATCH] Cleanup usbnet_probe() return value handling Peter Korsgaard wrote: >>>>>> "David" == David Brownell <david-b@...bell.net> writes: > > Hi, > > David> I'd rather see the later test updated to match this one. > David> (Good catch!) > > David> The return convention is "negative means error". There's > David> code in USB which has multiple nonnegative success codes. > > Ok, updated patch does that instead. > > David> In particular usb_control_msg(), which would very naturally > David> used as the body of a bind() method, returns negative or > David> the number of bytes transferred. > > Yeah, that was the original problem in my dm9601 driver. > > usbnet_probe() handles a positive return value from the driver bind() > function as success, but will later only setup the status handler if the > return value was zero, leading to confusion. Patch adjusts this to accept > positive values as success in both checks. > > Signed-off-by: Peter Korsgaard <jacmet@...site.dk> > --- > drivers/net/usb/usbnet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists