[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200707030010.25431.mb@bu3sch.de>
Date: Tue, 3 Jul 2007 00:10:24 +0200
From: Michael Buesch <mb@...sch.de>
To: "Kok, Auke" <auke-jan.h.kok@...el.com>
Cc: Christoph Hellwig <hch@...radead.org>,
Stephen Hemminger <shemminger@...ux-foundation.org>,
"Veeraiyan, Ayyappan" <ayyappan.veeraiyan@...el.com>,
Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org,
arjan@...ux.intel.com, akpm@...ux-foundation.org
Subject: Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...
On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote:
> well, FWIW when I started looking at adding these flags I looked in various
> subsystems in the kernel and picked an implementation that suited. Guess what
> pci.h has? ...:
>
> unsigned int msi_enabled:1;
> unsigned int msix_enabled:1;
>
> this is literally where I copied the example from
>
> I suppose I can fix those, but I really don't understand what all the fuzz is
> about here. We're only conserving memory and staying far away from the real
I'm not sure if these bitfields actually _do_ conserve memory.
Generated code gets bigger (need bitwise masks and stuff).
Code also needs memory. It probably only conserves memory, if the
structure is instanciated a lot.
--
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists