netdev - Re: [PATCH] ps3: gigabit ethernet driver for PS3, take2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.62.0707031709040.8675@pademelon.sonytel.be>
Date:	Tue, 3 Jul 2007 17:11:48 +0200 (CEST)
From:	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
To:	Jeff Garzik <jeff@...zik.org>
cc:	Masakazu Mokuno <mokuno@...sony.co.jp>, netdev@...r.kernel.org,
	Geoff Levand <geoffrey.levand@...sony.com>,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Subject: Re: [PATCH] ps3: gigabit ethernet driver for PS3, take2

On Tue, 3 Jul 2007, Jeff Garzik wrote:
> Masakazu Mokuno wrote:
> > > > --- a/drivers/net/Makefile
> > > > +++ b/drivers/net/Makefile
> > > > @@ -60,6 +60,8 @@ obj-$(CONFIG_TIGON3) += tg3.o
> > > >  obj-$(CONFIG_BNX2) += bnx2.o
> > > >  spidernet-y += spider_net.o spider_net_ethtool.o
> > > >  obj-$(CONFIG_SPIDER_NET) += spidernet.o sungem_phy.o
> > > > +obj-$(CONFIG_GELIC_NET) += ps3_gelic.o
> > > > +ps3_gelic-objs += gelic_net.o
> > > >  obj-$(CONFIG_TC35815) += tc35815.o
> > > >  obj-$(CONFIG_SKGE) += skge.o
> > > >  obj-$(CONFIG_SKY2) += sky2.o
> > > > --- /dev/null
> > > > +++ b/drivers/net/gelic_net.c
> > > The patch does not reflect the new name...
> > 
> > The driver's module name is 'ps3_gelic.ko' and the souce file names are
> > 'gelic_net.{c,h}'.  As Geoff Levand said in the mail dated June 16, we
> > have plan to add wireless support and its file name would be
> > gelic_wireless.c.
> > If this support added, the make file would be:
> > 
> >   obj-$(CONFIG_GELIC_NET) += ps3_gelic.o
> >   gelic-$(CONFIG_GELIC_WIRELESS) += gelic_wireless.o
> >   ps3_gelic-objs += gelic_net.o $(gelic-y)
> 
> 
> For single-file modules, the source file prefix should match the output file
> prefix.
> 
> No Linux driver does it any other way.  It leads to confusion.

Right now it's indeed a single source file module.

However, we are working on wireless support for gelic (the virtual network
device supports both wired and wireless), which will add a second source file.

So you want us to rename
  1. gelic_net.c -> ps3_gelic_net.c
  2. gelic_wireless.c -> ps3_gelic_wireless.c
while the actual kernel module will be ps3_gelic.{o,ko}, right?

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   Geert.Uytterhoeven@...ycom.com	
Internet: http://www.sony-europe.com/
 	
Sony Network and Software Technology Center Europe	
A division of Sony Service Centre (Europe) N.V.	
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
VAT BE 0413.825.160 · RPR Brussels	
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619