netdev - Re: [PATCH] ps3: gigabit ethernet driver for PS3, take2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <468A4AED.7080907@garzik.org>
Date:	Tue, 03 Jul 2007 09:11:09 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Masakazu Mokuno <mokuno@...sony.co.jp>
CC:	netdev@...r.kernel.org, Geoff Levand <geoffrey.levand@...sony.com>,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Subject: Re: [PATCH] ps3: gigabit ethernet driver for PS3, take2

Masakazu Mokuno wrote:
>>> --- a/drivers/net/Makefile
>>> +++ b/drivers/net/Makefile
>>> @@ -60,6 +60,8 @@ obj-$(CONFIG_TIGON3) += tg3.o
>>>  obj-$(CONFIG_BNX2) += bnx2.o
>>>  spidernet-y += spider_net.o spider_net_ethtool.o
>>>  obj-$(CONFIG_SPIDER_NET) += spidernet.o sungem_phy.o
>>> +obj-$(CONFIG_GELIC_NET) += ps3_gelic.o
>>> +ps3_gelic-objs += gelic_net.o
>>>  obj-$(CONFIG_TC35815) += tc35815.o
>>>  obj-$(CONFIG_SKGE) += skge.o
>>>  obj-$(CONFIG_SKY2) += sky2.o
>>> --- /dev/null
>>> +++ b/drivers/net/gelic_net.c
>> The patch does not reflect the new name...
> 
> The driver's module name is 'ps3_gelic.ko' and the souce file names are
> 'gelic_net.{c,h}'.  As Geoff Levand said in the mail dated June 16, we
> have plan to add wireless support and its file name would be gelic_wireless.c.
> If this support added, the make file would be:
> 
>   obj-$(CONFIG_GELIC_NET) += ps3_gelic.o
>   gelic-$(CONFIG_GELIC_WIRELESS) += gelic_wireless.o
>   ps3_gelic-objs += gelic_net.o $(gelic-y)


For single-file modules, the source file prefix should match the output 
file prefix.

No Linux driver does it any other way.  It leads to confusion.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html