lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Jul 2007 14:34:07 -0700 From: Stephen Hemminger <shemminger@...ux-foundation.org> To: Yinghai.Lu@....COM Cc: Andrew Morton <akpm@...ux-foundation.org>, Andi Kleen <ak@...e.de>, Greg KH <greg@...ah.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org Subject: Re: [PATCH 2/2] net: make net and forcedeth to use kmalloc_node On Tue, 03 Jul 2007 14:28:50 -0700 Yinghai Lu <Yinghai.Lu@....COM> wrote: > Stephen Hemminger wrote: > > On Tue, 3 Jul 2007 11:58:40 -0700 > > Andrew Morton <akpm@...ux-foundation.org> wrote: > > > >> On Fri, 29 Jun 2007 13:30:36 -0700 > >> Yinghai Lu <Yinghai.Lu@....COM> wrote: > >> > >>> [PATCH 2/2] net: make net and forcedeth to use kmalloc_node > >> Please copy netdev@...r.kernel.org on net patches. > >> > >> This patch modifies a net driver as well as the networking core. These > >> subsytems have different maintainers who run different development trees. > >> Consequently I must split your patch into two and change their titles and > >> changelogs appropriately. > >> > >> Please do this for us in future, thanks. > >> > >> > >>> diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c > >>> index 42ba1c0..6d53b52 100644 > >>> --- a/drivers/net/forcedeth.c > >>> +++ b/drivers/net/forcedeth.c > >>> @@ -1383,7 +1383,7 @@ static int nv_alloc_rx(struct net_device *dev) > >>> less_rx = np->last_rx.orig; > >>> > >>> while (np->put_rx.orig != less_rx) { > >>> - struct sk_buff *skb = dev_alloc_skb(np->rx_buf_sz + NV_RX_ALLOC_PAD); > >>> + struct sk_buff *skb = dev_alloc_skb_node(np->rx_buf_sz + NV_RX_ALLOC_PAD, dev_to_node(&dev->dev)); > >> If we're going to do this then it would probably make sense to change > >> dev_alloc_skb_node() so that it takes a `struct net_device *' rather than a > >> bare node-id. That's a call which the net guys will need to make, which is > >> why we cc them on our emails. > > > > The driver should use netdev_alloc_skb. That routine is supposed to be overriden > > on architecture's that need per node changes. > > do you mean: > use dev_alloc_skb_node for numa arch. Look at __netdev_alloc_skb() source. It does all the necessary dev_to_node() stuff. dev_alloc_skb is the old routine and kept around only because not all usage has been converted yet. It should probably be deprecated at some point. -- Stephen Hemminger <shemminger@...ux-foundation.org> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists