netdev - Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae4a4a920707031501h52aa2657o691ebba4e108a61d@mail.gmail.com>
Date:	Tue, 3 Jul 2007 15:01:24 -0700
From:	"Ayyappan Veeraiyan" <Ayyappan.Veeraiyan@...el.com>
To:	"Christoph Hellwig" <hch@...radead.org>,
	"Stephen Hemminger" <shemminger@...ux-foundation.org>
Cc:	"Jeff Garzik" <jeff@...zik.org>, netdev@...r.kernel.org,
	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>,
	arjan@...ux.intel.com, akpm@...ux-foundation.org
Subject: Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

On 7/2/07, Veeraiyan, Ayyappan <ayyappan.veeraiyan@...el.com> wrote:
> On 7/2/07, Christoph Hellwig <hch@...radead.org> wrote:

> The submitted driver code supports single queue version in case of MSIX
> allocation failures... As I said in the other mail, I feel, restricting
> to single Rx queue in NAPI mode is better approach till Stephen's and
> DaveM' work of separating NAPI from netdevice is done..
>
> > Lots of drivers where the interface name is assigned after request_irq
> > just use an internal name, e.g. ixgbeX in the case of this driver.
> >

Actually looking closer, we don't need to worry about interface name
change after request_irq. This driver calls request_irq only on
interface up. If interface is up, kernel (dev.c) doesn't allow the
name change. So it is a non-issue for this driver.

Ayyappan
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html