lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8bd0f97a0707141249y2c90a59cs356aa3cef357f721@mail.gmail.com> Date: Sat, 14 Jul 2007 15:49:21 -0400 From: "Mike Frysinger" <vapier.adi@...il.com> To: "Michael Buesch" <mb@...sch.de> Cc: bryan.wu@...log.com, "Jeff Garzik" <jeff@...zik.org>, LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, "Andrew Morton" <akpm@...ux-foundation.org> Subject: Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver On 7/14/07, Michael Buesch <mb@...sch.de> wrote: > On Saturday 14 July 2007 20:49:53 Bryan Wu wrote: > > +static int __init bf537mac_probe(struct net_device *dev) > > +{ > > + struct bf537mac_local *lp = netdev_priv(dev); > > + int retval; > > + > > + /* Grab the MAC address in the MAC */ > > + *(u32 *) (&(dev->dev_addr[0])) = bfin_read_EMAC_ADDRLO(); > > + *(u16 *) (&(dev->dev_addr[4])) = (u16) bfin_read_EMAC_ADDRHI(); > > Endianess broken. > > > +struct dma_config_reg { > > + unsigned short b_DMA_EN:1; /* Bit 0 : DMA Enable */ > > + unsigned short b_WNR:1; /* Bit 1 : DMA Direction */ > > + unsigned short b_WDSIZE:2; /* Bit 2 & 3 : DMA Tranfer Word size */ > > + unsigned short b_DMA2D:1; /* Bit 4 : DMA Mode 2D or 1D */ > > + unsigned short b_RESTART:1; /* Bit 5 : Retain the FIFO */ > > + unsigned short b_DI_SEL:1; /* Bit 6 : Data Interrupt Timing Select */ > > + unsigned short b_DI_EN:1; /* Bit 7 : Data Interrupt Enable */ > > + unsigned short b_NDSIZE:4; /* Bit 8 to 11 : Flex descriptor Size */ > > + unsigned short b_FLOW:3; /* Bit 12 to 14 : FLOW */ > > +}; > > This is most likely not endianess safe. do we really need to care about this ? this is a driver for a MAC which can only be found on Blackfin processors and Blackfin itself is only little endian. -mike - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists