lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 14 Jul 2007 16:33:27 -0400 From: Jeff Garzik <jeff@...zik.org> To: Michael Buesch <mb@...sch.de> CC: Mike Frysinger <vapier.adi@...il.com>, bryan.wu@...log.com, LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH 1/3] Blackfin ethernet driver: on chip ethernet MAC controller driver Michael Buesch wrote: > Well, this bitfield _might_ be OK (although I don't like bitfields > at all), but the above pointer casting stuff should really use > leXX_to_cpu. It's so easy to use and it is easier to read and > maintain the code afterwards. > If the bitfield stays, a comment must be added. Regardless of endian issues, the bitfield usage should go away. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists