[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20070718.152249.43010301.davem@davemloft.net>
Date: Wed, 18 Jul 2007 15:22:49 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: kaber@...sh.net
Cc: florian.fainelli@...ecomint.eu, netdev@...r.kernel.org,
rpurdie@...ys.net
Subject: Re: [PATCH] Add a network activity LED trigger
From: Patrick McHardy <kaber@...sh.net>
Date: Wed, 18 Jul 2007 15:54:56 +0200
> Florian Fainelli wrote:
> >> Besides missing a declaration and not linking without the network
> >> LED config option, its pretty ridiculous to call this for every
> >> packet just to make a led blink.
> >>
> >
> > Could you suggest me a better way to do so ? The code was highly inspired from
> > what is done with the IDE trigger. The declaration is done in linux/leds.h,
> > which is included in dev.c for that purpose.
> >
>
> Maybe just increment a variable and periodically check it or something
> like that.
Yes please, calling this millions of times per second on a high end
router is just not smart.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists