netdev - Re: [PATCH] negative groups in netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070718.020821.15264737.davem@davemloft.net>
Date:	Wed, 18 Jul 2007 02:08:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] negative groups in netlink_setsockopt

From: Johannes Berg <johannes@...solutions.net>
Date: Tue, 17 Jul 2007 14:26:04 +0200

> Reading netlink_setsockopt it's not immediately clear why there isn't a
> bug when you pass in negative numbers, the reason being that the >=
> comparison is really unsigned although 'val' is signed because
> nlk->ngroups is unsigned. Make 'val' unsigned too.
> 
> Signed-off-by: Johannes Berg <johannes@...solutions.net>

Applied, but I updated the "(int __user *)" cast in
get_user() to match as well when applying this.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html