netdev - Re: [PATCH] negative groups in netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1184753452.4658.9.camel@johannes.berg>
Date:	Wed, 18 Jul 2007 12:10:52 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] negative groups in netlink_setsockopt

On Wed, 2007-07-18 at 02:08 -0700, David Miller wrote:
> From: Johannes Berg <johannes@...solutions.net>
> Date: Tue, 17 Jul 2007 14:26:04 +0200
> 
> > Reading netlink_setsockopt it's not immediately clear why there isn't a
> > bug when you pass in negative numbers, the reason being that the >=
> > comparison is really unsigned although 'val' is signed because
> > nlk->ngroups is unsigned. Make 'val' unsigned too.
> > 
> > Signed-off-by: Johannes Berg <johannes@...solutions.net>
> 
> Applied, but I updated the "(int __user *)" cast in
> get_user() to match as well when applying this.

Oh, good catch, thanks.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)