lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 Jul 2007 15:33:57 +0200 From: Patrick McHardy <kaber@...sh.net> To: Florian Fainelli <florian.fainelli@...ecomint.eu> CC: netdev@...r.kernel.org, rpurdie@...ys.net Subject: Re: [PATCH] Add a network activity LED trigger Florian Fainelli wrote: > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index 87d2046..fdc5a8a 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -128,5 +128,12 @@ config LEDS_TRIGGER_HEARTBEAT > load average. > If unsure, say Y. > > +config LEDS_TRIGGER_NETWORK_ACT > + tristate "LED Network Activity Trigger" Module isn't possible, you call the led trigger from net/core/dev.c. > diff --git a/net/core/dev.c b/net/core/dev.c > index ee051bb..a3a4115 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -117,6 +117,7 @@ > #include <linux/err.h> > #include <linux/ctype.h> > #include <linux/if_arp.h> > +#include <linux/leds.h> > > /* > * The list of packet types we will receive (as opposed to discard) > @@ -1523,6 +1524,7 @@ gso: > * stops preemption for RCU. > */ > rcu_read_lock_bh(); > + ledtrig_network_activity(); Besides missing a declaration and not linking without the network LED config option, its pretty ridiculous to call this for every packet just to make a led blink. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists