netdev - Re: [PATCH] Add a network activity LED trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070718144122.00f28346@oldman>
Date:	Wed, 18 Jul 2007 14:41:22 +0100
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Florian Fainelli <florian.fainelli@...ecomint.eu>
Cc:	netdev@...r.kernel.org, rpurdie@...ys.net
Subject: Re: [PATCH] Add a network activity LED trigger

On Wed, 18 Jul 2007 15:27:38 +0200
Florian Fainelli <florian.fainelli@...ecomint.eu> wrote:

> Hi all,
> 
> This patch adds a new LED trigger, based on network activity. It gathers 
> activity from net/core/dev.c and can be used as a LED trigger by 
> specifying "network-activity". Further version should allow the user to 
> specify the network interface to bind a LED to. This trigger is a "simple" 
> trigger as defined by the LED subsystem.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@...ecomint.eu>
> -- 

You are slowing down the network receive path even if LED is not used.

Doing mod_timer() is expensive, on a busy system you would be adding
another lock roundtrip and list operation for each incoming packet.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html