lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <469FF922.2090900@intel.com> Date: Thu, 19 Jul 2007 16:52:02 -0700 From: "Kok, Auke" <auke-jan.h.kok@...el.com> To: Jeff Garzik <jeff@...zik.org> CC: NetDev <netdev@...r.kernel.org>, Arjan van de Ven <arjan@...ux.intel.com>, "Ronciak, John" <john.ronciak@...el.com>, Mitch Williams <mitch.a.williams@...el.com> Subject: Re: ANNOUNCE: igb: Intel 82575 Gigabit Ethernet driver (PCI-Express) Jeff Garzik wrote: > Kok, Auke wrote: >> http://foo-projects.org/~sofar/igb.patch [558K] >> http://foo-projects.org/~sofar/igb.patch.bz2 [98K] > > Just took a look at this. > > This has the same problem as in the other thread -- huge internal API -- > except this time, the problem is emphasized by the fact that the > majority of the API hooks only have a single user, making each hook and > API entry point demonstrably useless overhead. > > Please remove the useless internal API and resubmit. Why don't you accept it now and allow us the time to work on this in the coming period? The driver works, performs better than all 8257x hardware and uses less CPU utilization. That must be good for everyone. Keeping it outside of the linux tree is just going to postpone testing the non-internal API parts. > PLEASE take a look at how bnx2 and tg3 are structured. They don't use PHYlib. Nobody is perfect... We can and we should be able to _not_ agree on certain things and live together just fine. While I agree that some designs are better, the current internal API design has worked really good for us and allowed us to develop this driver and ixgbe in much faster rate than ever before. It was most useful in silicon validation and extremely flexible for us. At one point, the 82575 silicon was even supporter by the e1000 driver, because this internal API made it so easy to add new hardware support. For obvious reasons (differences in hw) we decided to split this driver off. It served a good purpose. We can improve it, and I sure want to do that, but I think it's better to improve something *upstream*, then going back working at things offline without having any certainty that you will accept it after I get back, since you might just reject it on another argument, etc. It will take quite some effort and convincing to make this happen, and it would help a lot if we can work with/in the community on that, instead of off-line. That will also give the non-internal API parts the better testing. Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists