netdev - Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [4/8]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070719140730.GC12892@xyzzy.farnsworth.org>
Date:	Thu, 19 Jul 2007 07:07:30 -0700
From:	"Dale Farnsworth" <dale@...nsworth.org>
To:	"Steven J. Hill" <sjhill@...litydiluted.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [4/8]

On Thu, Jul 19, 2007 at 04:53:31AM +0000, Steven J. Hill wrote:
> Add main 642xx support to 'drivers/net/mv643xx_eth.c' file.

As Christoph said, this quantity of ifdefs really hurt the
maintainability.  Refactoring is needed.  Also, since in arch/powerpc
we want to have a single kernel support both MV64[34]60 and GT64260
(determined at runtime) and their register sets are so different, I
think the best approach is to have a separate module for the GT64260.

Also, please follow Documentation/SubmittingPatches.  Good subjects,
diffstats and "diff -p" would have been helpful in reviewing this series.

-Dale
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html