netdev - Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [6/8]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070719141524.GE12892@xyzzy.farnsworth.org>
Date:	Thu, 19 Jul 2007 07:15:24 -0700
From:	"Dale Farnsworth" <dale@...nsworth.org>
To:	"Steven J. Hill" <sjhill@...litydiluted.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [6/8]

On Thu, Jul 19, 2007 at 04:55:36AM +0000, Steven J. Hill wrote:
> Fix the TX bytes statistics counter to, um, actually count.
> 
> Signed-off-by: Steven J. Hill <sjhill1@...kwellcollins.com>
> ---

> --- linux-2.6.22.1/drivers/net/mv643xx_eth.c	2007-07-18 21:51:49.000000000 -0500
> +++ linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c	2007-07-18 21:44:07.000000000 -0500
> @@ -1506,7 +1511,7 @@
>  	spin_lock_irqsave(&mp->lock, flags);
>  
>  	eth_tx_submit_descs_for_skb(mp, skb);
> -	stats->tx_bytes = skb->len;
> +	stats->tx_bytes += skb->len;
>  	stats->tx_packets++;
>  	dev->trans_start = jiffies;
>  

Good fix, thanks.  Please resubmit per the guidelines in
Documentation/SubmittingPatches.

-Dale
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html