netdev - Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [7/8]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Jul 2007 07:21:59 -0700
From:	"Dale Farnsworth" <dale@...nsworth.org>
To:	"Steven J. Hill" <sjhill@...litydiluted.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [7/8]

On Thu, Jul 19, 2007 at 04:56:51AM +0000, Steven J. Hill wrote:
> Get rid of global PHY spinlock.

You have replaced the use of the global PHY spinlock with a per-port spinlock.
However, the SMI register is shared by all ports.  The global lock is
needed to prevent simultaneous updates of the register by drivers for
multiple ports.

NAK

-Dale
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html