netdev - RE: NET_DMA: where do we ever call dma_skb_copy_datagram_iovec() with NULL pinned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BAE9DCEF64577A439B3A37F36F9B691C02BBE409@orsmsx418.amr.corp.intel.com>
Date:	Tue, 24 Jul 2007 11:14:46 -0700
From:	"Nelson, Shannon" <shannon.nelson@...el.com>
To:	"Al Viro" <viro@....linux.org.uk>, <netdev@...r.kernel.org>
Cc:	"Leech, Christopher" <christopher.leech@...el.com>,
	"Andrew Grover" <andy.grover@...il.com>
Subject: RE: NET_DMA: where do we ever call dma_skb_copy_datagram_iovec() with NULL pinned_list?

Al Viro:
>
>	AFAICS, all callers of dma_skb_copy_datagram_iovec()
>are either
>	* recursive for fragments, pass pinned_list unchanged or
>	* called from tcp, with pinned_list coming from
>tp->ucopy.pinned_list and only when tp->ucopy.dma_chan is non-NULL.
>
>Now, all non-NULL assignments to ->dma_chan have the same form:
>	if (!tp->ucopy.dma_chan && tp->ucopy.pinned_list)
>		tp->ucopy.dma_chan = get_softnet_dma();
>IOW, if ->ucopy.pinned_list stays NULL, ->ucopy.dma_chan will 
>do the same.
>
>Moreover, any place that resets ->ucopy.pinned_list will also reset
>->ucopy.dma_chan.
>
>IOW, we can't ever get non-NULL tp->ucopy.dma_chan while 
>tp->ucopy.pinned_list
>is NULL.  So how can we ever get to the dma_memcpy_to_kernel_iovec()?

It looks like this is "extra" code.  The history seems to be that it was
thought to be useful for internal copying, perhaps for smbfs or iSCSI,
as the comment suggests.  However, since no one is using it, it can
probably come out.  If there is no argument, I'll post a patch to remove
it.

sln
--
======================================================================
Mr. Shannon Nelson                 LAN Access Division, Intel Corp.
Shannon.Nelson@...el.com                I don't speak for Intel
(503) 712-7659                    Parents can't afford to be squeamish.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html