netdev - Re: [PATCH RFC]: napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070725.190245.68070169.davem@davemloft.net>
Date:	Wed, 25 Jul 2007 19:02:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	shemminger@...ux-foundation.org, netdev@...r.kernel.org,
	hadi@...erus.ca, rusty@...tcorp.com.au
Subject: Re: [PATCH RFC]: napi_struct V4

From: Jeff Garzik <jeff@...zik.org>
Date: Wed, 25 Jul 2007 22:00:31 -0400

> David Miller wrote:
> > From: Jeff Garzik <jgarzik@...ox.com>
> > Date: Wed, 25 Jul 2007 21:55:08 -0400
> > 
> >> I don't see any logic to your request, only added overhead for no reason.
> > 
> > There may be some flawed logic in what Stephen stated, but
> > the change really is needed.
> > 
> > It must be atomic to execute the:
> > 
> > 	enable_interrupts();
> > 	netif_rx_complete();
> > 
> > sequence wrt. the same code path in the interrupt handler.
> 
> Sure.  And how did the existing code fail to achieve that?

The interrupt handler can run on another cpu in betwen those two
statements, running the NAPI test-and-do-something operations in
parallel with the netif_rx_complete() which causes problems as Rusty
and I discussed yesterday.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html