netdev - RE: [NET_SCHED]: Fix prio/ingress classification logic error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 26 Jul 2007 09:31:42 -0700
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	"Patrick McHardy" <kaber@...sh.net>,
	"David Miller" <davem@...emloft.net>
Cc:	"Linux Netdev List" <netdev@...r.kernel.org>
Subject: RE: [NET_SCHED]: Fix prio/ingress classification logic error

> This is the final fix for the problem Peter reported.
> Turns out most other schedulers get it right, the only other 
> case is ingress setting skb->tc_index to the uninitialized 
> value of res.classid.

I've applied this and tested prio and rr, and everything is happy again.
Thanks for finding this and putting the patch together.

I got lost in looking for the bug in the u32_classify() code, and missed
the easier defect...

Thanks again Patrick,
-PJ Waskiewicz
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html