lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070802093659.GB27748@uranus.ravnborg.org> Date: Thu, 2 Aug 2007 11:36:59 +0200 From: Sam Ravnborg <sam@...nborg.org> To: Matt Mackall <mpm@...enic.com> Cc: Jarek Poplawski <jarkao2@...pl>, Gabriel C <nix.or.die@...glemail.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, jason.wessel@...driver.com, amitkale@...syssoft.com Subject: Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 ) > > > > ... > > endif # NETDEVICES > > > > config NETPOLL > > depends on NETDEVICES > > def_bool NETCONSOLE > > > > config NETPOLL_TRAP > > bool "Netpoll traffic trapping" > > default n > > depends on NETPOLL > > > > config NET_POLL_CONTROLLER > > def_bool NETPOLL > > depends on NETPOLL > > > > > > seems to select NET_POLL_CONTROLLER after selecting NETPOLL, but > > still doesn't check for NETDEVICES dependency. > > That's odd. Adding Sam to the cc:. select is evil.... select will by brute force set a symbol equal to 'y' without visiting the dependencies. So abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set. In general use select only for non-visible symbols (no promts anywhere) and for symbols with no dependencies. That will limit the suefullness but on the other hand avoid the illegal configurations all over. kconfig should one day warn about such things but I have not fel inclined to dive into the matters hoping that Roman does one day. Sam - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists