netdev - Re: [PATCH 6/7] Make qdisc changeable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46B70EB4.70408@trash.net>
Date:	Mon, 06 Aug 2007 14:06:12 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Corey Hickey <bugfood-ml@...ooh.org>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 6/7] Make qdisc changeable.

Corey Hickey wrote:
> Patrick McHardy wrote:
> 
>>> +    if ((err = sfq_q_init(&tmp, opt)))
>>> +        return err;
>>
>>
>>
>> This will also use defaults for all unspecified values. It would
>> be more consistent with other qdiscs to only change those values
>> that are actually specified, so something like "tc qdisc change ...
>> perturb 10" will *only* change the perturbation parameter.
> 
> 
> I'm fixed this for all the parameters except one--your example above.
> Since 0 is a valid value for perturb, I can't see any clever way to
> differentiate between the user specifying "perturb 0" or leaving perturb
> unspecified. Either way, opt->perturb_period is 0.
> 
> The only way I can see would be to add another member, say,
> opt->perturb_specified, and use that accordingly. Unfortunately, this
> would break usage of sfq with older versions of tc, so I'm hoping
> there's a better approach.
> 
> Do you have any suggestions? I've looked at the other qdisc files and I
> don't see any other instances like this.

Maybe use the nested compat attribute and split the base SFQ
struct in the individual members ..
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html