netdev - Re: [PATCH net-2.6.22-rc7] xfrm beet interfamily support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46B70F2C.6090807@trash.net>
Date:	Mon, 06 Aug 2007 14:08:12 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Joakim Koskela <joakim.koskela@...t.fi>
CC:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-2.6.22-rc7] xfrm beet interfamily support

Joakim Koskela wrote:
> On Tuesday 17 July 2007 17:30:21 Joakim Koskela wrote:
> 
>>>>@@ -108,7 +108,8 @@ int xfrm4_rcv_encap(struct sk_buff *skb, __u16
>>>>encap_type) if (x->mode->input(x, skb))
>>>> 			goto drop;
>>>>
>>>>-		if (x->props.mode == XFRM_MODE_TUNNEL) {
>>>>+		if (x->props.mode == XFRM_MODE_TUNNEL ||
>>>>+		    x->props.mode == XFRM_MODE_BEET) {
>>>> 			decaps = 1;
>>>> 			break;
>>>> 		}
>>>
> It's been a while, but as a fyi in case there are comments / suggestions 
> before submitting the whole patch again - it seems that this had some 
> problems after all. Works ok for normal cases, but fails when using ip 
> options for the inner packet as they don't get processed after being 
> extracted from the pseudoheader. Calling something like ip_options_compile 
> from beet_mode's input when handling ipv4 would do the trick, but seems a bit 
> ugly & perhaps unsafe, I'd rather just put the whole packet through the loop 
> again.


Won't the options get parsed by ip_rcv() on the second reception?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html