netdev - Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070810.150625.105430969.davem@davemloft.net>
Date:	Fri, 10 Aug 2007 15:06:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vladislav.yasevich@...com
Cc:	netdev@...r.kernel.org, nhorman@...driver.com,
	lksctp-developers@...ts.sourceforge.net
Subject: Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

From: Vlad Yasevich <vladislav.yasevich@...com>
Date: Fri, 10 Aug 2007 16:46:03 -0400

> This patch introduces autotuning to the sctp buffer management code
> similar to the TCP.  The buffer space can be grown if the advertised
> receive window still has room.  This might happen if small message
> sizes are used, which is common in telecom environmens.
> New tunables are introduced that provide limits to buffer growth
> and memory pressure is entered if to much buffer spaces is used.
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@...com>

Applied, thanks Vlad.

Can you in the future fix up whitespace issues like this:

Adds trailing whitespace.
diff:21: 
Space in indent is followed by a tab.
diff:27: 	int amt;
Space in indent is followed by a tab.
diff:48: 		amt = asoc->base.sk->sk_sndbuf - amt;
Space in indent is followed by a tab.
diff:55:  	return amt;

I know where the "Space in indent" cases come from, you apply the
patch to merge it into a current tree, you get rejects, then you edit
in the foo.rej hunks by hand into the code but forget to remove the
extra leading whitespace characters.

:-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html