netdev - Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070810230126.GB3983@hmsreliant.homelinux.net>
Date:	Fri, 10 Aug 2007 19:01:26 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	vladislav.yasevich@...com, netdev@...r.kernel.org,
	lksctp-developers@...ts.sourceforge.net
Subject: Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

On Fri, Aug 10, 2007 at 03:06:25PM -0700, David Miller wrote:
> From: Vlad Yasevich <vladislav.yasevich@...com>
> Date: Fri, 10 Aug 2007 16:46:03 -0400
> 
> > This patch introduces autotuning to the sctp buffer management code
> > similar to the TCP.  The buffer space can be grown if the advertised
> > receive window still has room.  This might happen if small message
> > sizes are used, which is common in telecom environmens.
> > New tunables are introduced that provide limits to buffer growth
> > and memory pressure is entered if to much buffer spaces is used.
> > 
> > Signed-off-by: Neil Horman <nhorman@...driver.com>
> > Signed-off-by: Vlad Yasevich <vladislav.yasevich@...com>
> 
> Applied, thanks Vlad.
> 
> Can you in the future fix up whitespace issues like this:
> 
> Adds trailing whitespace.
> diff:21: 
> Space in indent is followed by a tab.
> diff:27: 	int amt;
> Space in indent is followed by a tab.
> diff:48: 		amt = asoc->base.sk->sk_sndbuf - amt;
> Space in indent is followed by a tab.
> diff:55:  	return amt;
> 
> I know where the "Space in indent" cases come from, you apply the
> patch to merge it into a current tree, you get rejects, then you edit
> in the foo.rej hunks by hand into the code but forget to remove the
> extra leading whitespace characters.
> 
> :-)

Thanks for applying this Dave, but something seems to have occured during your
application.  The commitdiff:
http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.24.git;a=commitdiff;h=e20e5d698dcccd2e84ee2e1e482b0b203f885c00
only shows applications to socket.c, while the patch that vlad sent you changed
much more than that.  Not sure If I'm seeing something thats transient, but I
wanted to bring it to your attention in the event that something has in fact
gone awry.  

Thanks & Regards to you both
Neil

-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *nhorman@...driver.com
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html