netdev - Re: [patch 19/28] netconsole: Remove bogus check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Aug 2007 15:28:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, satyam@...radead.org,
	k-keiichi@...jp.nec.com, mpm@...enic.com
Subject: Re: [patch 19/28] netconsole: Remove bogus check

From: akpm@...ux-foundation.org
Date: Fri, 10 Aug 2007 14:12:03 -0700

> From: Satyam Sharma <satyam@...radead.org>
> 
> Based upon initial work by Keiichi Kii <k-keiichi@...jp.nec.com>.
> 
> The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is
> set by netpoll_setup(), which is called by init_netconsole() before
> register_console(), so write_msg() cannot be triggered unless netpoll_setup()
> successfully set np.dev.  Also np.dev cannot go away from under us, because
> netpoll_setup() grabs us reference on it.  So let's remove the bogus check.
> 
> Signed-off-by: Satyam Sharma <satyam@...radead.org>
> Acked-by: Keiichi Kii <k-keiichi@...jp.nec.com>
> Acked-by: Matt Mackall <mpm@...enic.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied to net-2.6.24, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html