netdev - Re: [patch 20/28] netconsole: Simplify boot/module option setup logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070810.153000.40145488.davem@davemloft.net>
Date:	Fri, 10 Aug 2007 15:30:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, satyam@...radead.org,
	k-keiichi@...jp.nec.com, mpm@...enic.com
Subject: Re: [patch 20/28] netconsole: Simplify boot/module option setup
 logic

From: akpm@...ux-foundation.org
Date: Fri, 10 Aug 2007 14:12:03 -0700

> From: Satyam Sharma <satyam@...radead.org>
> 
> Based upon initial work by Keiichi Kii <k-keiichi@...jp.nec.com>.
> 
> Presently, boot/module parameters are set up quite differently for the case of
> built-in netconsole (__setup() -> obsolete_checksetup() ->
> netpoll_parse_options() -> strlen(config) == 0 in init_netconsole()) vs
> modular netconsole (module_param_string() -> string copied to the config
> variable -> strlen(config) != 0 init_netconsole() -> netpoll_parse_options()).
> 
> This patch makes both of them similar by doing exactly the equivalent of a
> module_param_string() in option_setup() also -- just copying the param string
> passed from the kernel command line into "config" variable.  So,
> strlen(config) != 0 in both cases, and netpoll_parse_options() is always
> called from init_netconsole(), thus making the setup logic for both cases
> similar.
> 
> Now, option_setup() is only ever called / used for the built-in case, so we
> put it inside a #ifndef MODULE, otherwise gcc will complain about
> option_setup() being "defined but not used".  Also, the "configured" variable
> is redundant with this patch and hence removed.
> 
> Signed-off-by: Satyam Sharma <satyam@...radead.org>
> Signed-off-by: Keiichi Kii <k-keiichi@...jp.nec.com>
> Acked-by: Matt Mackall <mpm@...enic.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied to net-2.6.24, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html