[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20070810.153351.21236141.davem@davemloft.net>
Date: Fri, 10 Aug 2007 15:33:51 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: akpm@...ux-foundation.org
Cc: netdev@...r.kernel.org, satyam@...radead.org,
k-keiichi@...jp.nec.com, mpm@...enic.com
Subject: Re: [patch 25/28] netconsole: Support multiple logging targets
From: akpm@...ux-foundation.org
Date: Fri, 10 Aug 2007 14:12:07 -0700
> From: Satyam Sharma <satyam@...radead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@...jp.nec.com>.
>
> This patch introduces support for multiple targets, independent of
> CONFIG_NETCONSOLE_DYNAMIC -- this is useful even in the default case and
> (including the infrastructure introduced in previous patches) doesn't really
> add too many bytes to module text. All the complexity (and size) comes with
> the dynamic reconfigurability / userspace interface patch, and so it's
> plausible users may want to keep this enabled but that disabled (say to avoid
> a dependency on CONFIG_CONFIGFS_FS too).
>
> Also update documentation to mention the use of ";" separator to specify
> multiple logging targets in the boot/module option string.
>
> Brief overview:
>
> We maintain a target_list (and corresponding lock). Get rid of the static
> "default_target" and introduce allocation and release functions for our
> netconsole_target objects (but keeping sure to preserve previous behaviour
> such as default values). During init_netconsole(), ";" is used as the
> separator to identify multiple target specifications in the boot/module option
> string. The target specifications are parsed and netpolls setup. During
> exit, the target_list is torn down and all items released.
>
> Signed-off-by: Satyam Sharma <satyam@...radead.org>
> Signed-off-by: Keiichi Kii <k-keiichi@...jp.nec.com>
> Cc: Matt Mackall <mpm@...enic.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
Applied to net-2.6.24, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists