lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1187009029.27916.107.camel@johannes.berg>
Date:	Mon, 13 Aug 2007 14:43:49 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	jbenc@...e.cz, flamingice@...rmilk.net, jeff@...zik.org
Subject: Re: [PATCH 1/4] Net: mac80211, remove bitfields from struct
	ieee80211_tx_packet_data

On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote:

> +	if (control->flags & IEEE80211_TXCTL_REQ_TX_STATUS)
> +		pkt_data->flags |= IEEE80211_TXPD_REQ_TX_STATUS;
> +	if (control->flags & IEEE80211_TXCTL_DO_NOT_ENCRYPT)
> +		pkt_data->flags |= IEEE80211_TXPD_DO_NOT_ENCRYPT;
> +	if (control->flags & IEEE80211_TXCTL_REQUEUE)
> +		pkt_data->flags |= IEEE80211_TXPD_REQUEUE;
> +	if (control->type == IEEE80211_IF_TYPE_MGMT)
> +		pkt_data->flags |= IEEE80211_TXPD_MGMT_IFACE;

This looks weird. Can't we just use the same flags?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ