netdev - Re: [PATCH 2/4] Net: mac80211, remove bitfields from struct ieee80211_txrx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1187009078.27916.109.camel@johannes.berg>
Date:	Mon, 13 Aug 2007 14:44:38 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	jbenc@...e.cz, flamingice@...rmilk.net, jeff@...zik.org
Subject: Re: [PATCH 2/4] Net: mac80211, remove bitfields from struct
	ieee80211_txrx_data

On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote:

> -	unsigned int fragmented:1; /* whether the MSDU was fragmented */
> +	/* whether the MSDU was fragmented */
> +#define IEEE80211_TXRXD_FRAGMENTED		BIT(0)
> +#define IEEE80211_TXRXD_TXUNICAST		BIT(1)
> +#define IEEE80211_TXRXD_TXPS_BUFFERED		BIT(2)
> +#define IEEE80211_TXRXD_TXPROBE_LAST_FRAG	BIT(3)
> +#define IEEE80211_TXRXD_RXIN_SCAN		BIT(4)

I know this isn't the style currently used, but could you put these
definitions before the struct declaration? That way, kerneldoc doesn't
totally screw up.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)