netdev - Re: [PATCH] improved xfrm_audit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070822.125157.43008100.davem@davemloft.net>
Date:	Wed, 22 Aug 2007 12:51:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	latten@...tin.ibm.com
Cc:	netdev@...r.kernel.org, linux-audit@...hat.com, sgrubb@...hat.com
Subject: Re: [PATCH] improved xfrm_audit_log() patch

From: David Miller <davem@...emloft.net>
Date: Tue, 21 Aug 2007 00:24:05 -0700 (PDT)

> Looks good, applied to net-2.6.24, thanks Joy.

Something is still buggered up in this patch, you can't add this local
"audit_info" variable unconditionally to these functions, and
alternatively you also can't add a bunch of ifdefs to xfrm_user.c to
cover it up either.

  CC [M]  net/xfrm/xfrm_user.o
net/xfrm/xfrm_user.c: In function .$,1rx.(Bxfrm_add_sa.$,1ry.(B:
net/xfrm/xfrm_user.c:450: warning: unused variable .$,1rx.(Baudit_info.$,1ry.(B
net/xfrm/xfrm_user.c: In function .$,1rx.(Bxfrm_del_sa.$,1ry.(B:
net/xfrm/xfrm_user.c:525: warning: unused variable .$,1rx.(Baudit_info.$,1ry.(B
net/xfrm/xfrm_user.c: In function .$,1rx.(Bxfrm_add_policy.$,1ry.(B:
net/xfrm/xfrm_user.c:1140: warning: unused variable .$,1rx.(Baudit_info.$,1ry.(B
net/xfrm/xfrm_user.c: In function .$,1rx.(Bxfrm_get_policy.$,1ry.(B:
net/xfrm/xfrm_user.c:1404: warning: unused variable .$,1rx.(Baudit_info.$,1ry.(B
net/xfrm/xfrm_user.c: In function .$,1rx.(Bxfrm_add_pol_expire.$,1ry.(B:
net/xfrm/xfrm_user.c:1651: warning: unused variable .$,1rx.(Baudit_info.$,1ry.(B
net/xfrm/xfrm_user.c: In function .$,1rx.(Bxfrm_add_sa_expire.$,1ry.(B:
net/xfrm/xfrm_user.c:1688: warning: unused variable .$,1rx.(Baudit_info.$,1ry.(B

So I'm going to revert for now.  Let me know when you have
a fixed version of the patch.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html